New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
composer.lock
validation failing
#23
Comments
Oh, I think I accidentally built it with php 8.2... Will have to look at it when I find more time to see how I can fix this because it's already tagged. Also I'll have to think about how I can avoid this issue in the future probably :) |
Great. Looking forward packaging this in Nix then... Thank you mate! |
Hello, Just took a closer look. It seems like the phar got compiled correctly and the lock file is valid given the way it has been built. There are 2 things in your diff:
Currently I'm building this stuff locally. It might make sense to either do it in a pipeline with stable dependencies or maybe through a flake to make sure it gets compiled consistently. However, I don't think the issue here is the provided lock file. |
Right, let me retry the procedure with PHP 8.1. |
I can reproduce the issue with PHP 8.1, see this quick screencast: https://asciinema.org/a/1vlHjh3G6RIiDQAk5nr66KQNY |
The validate problem might be related to the Line 43 in 36418a5
You might need to run this command on the grumphp directory as well, so that the composer.json file has the correct configuration as well. Which results in this lock: grumphp-shim/phar.composer.lock Lines 7090 to 7092 in 36418a5
The API version of composer plugins is set because you are using a more recent composer version as I do. Yet I don't think validate complains about this. |
@drupol Can you revalidate on tag v2.2.0? grumphp-shim/phar.composer.lock Lines 7090 to 7094 in b753259
|
Sadly nope :( https://asciinema.org/a/gldqtNIjSwXv1hMJOVB7VRdeJ Hint 1: How about committing |
Can you figure out exactly what is not ok? Hint 1 is not possible: I cannot set that config on the main repo, cause it's installable on al versions and otherwise ci will start fetching invalid resources maybe you could use the exact same composer command for setting the php config instead of patching? Hint 2 is possible but doesnt fix the issue right? Hint 3 not sure if you can install php without Json, but that shouldn't cause any issues right? I'm lacking time to doing deep dives into this. All the tools you need to build the lock a f phar are in this repo. Feel free to see if you can find a way to do this from within this repo. |
Hello @drupol, Thanks for guiding me through this at SymfonyCon. This should make it reproducable from your end: |
WOW, that's a breakthrough ! Thank you Toon !!!! |
Oh yes, forgot to mention: If you want the phparser task to work, you'll need to bake in |
Hello,
I'm trying to update the Nix package with the new Composer builder, and it's failing at validating the
composer.lock
file.Here's how to reproduce it locally:
Here's the diff of the updated
composer.lock
:Do you think you could have some time to look at it?
Related PRs:
The text was updated successfully, but these errors were encountered: