Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 2.6 dependencies #13

Closed
klipach opened this issue May 19, 2015 · 7 comments
Closed

Symfony 2.6 dependencies #13

klipach opened this issue May 19, 2015 · 7 comments

Comments

@klipach
Copy link
Contributor

klipach commented May 19, 2015

In composer.json all Symfony components require version 2.6 or above, but a lot of projects use Symfony 2.3 (like mine) because it is an LTS release. Is it possible to downgrade component versions to 2.3?

@veewee
Copy link
Contributor

veewee commented May 19, 2015

Hello @klipach,
I agree we should use the LTS version as the minimum version for Symfony.
Symfony ^2.3 seems the way to go for GrumPHP.
The solution requires some extra testing on all platforms to make sure everything is still working!

@veewee
Copy link
Contributor

veewee commented May 19, 2015

The composer.json is changed on the master branch so that you can use Symfony 2.3.
Commit: d12b1d6

The package we use for git actions, requires symfony process 2.4.
This results in an unresolvable error:
Your requirements could not be resolved to an installable set of packages.

I created a ticket on the official repository:
gitonomy/gitlib#85

When this ticket is resolved, I will be testing with Symfony 2.3 on Linux and Windows.

@klipach
Copy link
Contributor Author

klipach commented May 20, 2015

Yesterday i checked the same solution locally, i had a problem with dependency injection https://github.com/phpro/grumphp/blob/master/resources/config/services.yml#L42 there is no support for expression engine for DI 2.3 https://github.com/symfony/DependencyInjection/blob/2.3/composer.json

@veewee
Copy link
Contributor

veewee commented May 20, 2015

This means that the lowest we can currently go without modifying the code is Symfony 2.4.
I will still need to test with version 2.4 to make sure all features will work.

@klipach
Copy link
Contributor Author

klipach commented May 26, 2015

it is no so easy to downgrade to fit Symfony LTS version. I think you can close this ticket.

@veewee
Copy link
Contributor

veewee commented May 26, 2015

LTS is probably not possible. But we will aim to make the Symfony version as low as possible.
V2.4 might work. I will keep this ticket open until we tested with some projects.

@veewee
Copy link
Contributor

veewee commented May 30, 2015

It seems to work with Symfony 2.4. So that will be our minimum dependency.

@veewee veewee closed this as completed May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants