Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'blocking' flag to a Task in the TaskRunner #17

Closed
veewee opened this issue May 26, 2015 · 3 comments
Closed

Add 'blocking' flag to a Task in the TaskRunner #17

veewee opened this issue May 26, 2015 · 3 comments
Milestone

Comments

@veewee
Copy link
Contributor

veewee commented May 26, 2015

In a Task service it must be possible to add a "blocking" tag to the service configuration.
E.g.:

parameters:
    tasks:
        taskname:
            metadata:
                blocking: false

By default all tasks are blocking. A user can overwrite the task service to be non blocking.
When a task is blocking, the errors will be fatal and shown in red.
When a task is not blocking, the error will not be fatal. A yellow error message will be displayed, but the changes will be commited.

The blocking flag of a task should be read when a tasks fails.
The metadata functionallity is already available with the getTaskMetadata() method on the GrumPHP object.

More information: https://github.com/phpro/grumphp/blob/master/doc/tasks.md#metadata

@aderuwe
Copy link
Contributor

aderuwe commented Dec 11, 2015

Shouldn't we plan to support this option in grumphp.yml?

@veewee
Copy link
Contributor Author

veewee commented Dec 11, 2015

@aderuwe: I changed the description based on one of the previous commits.

@aderuwe
Copy link
Contributor

aderuwe commented Dec 11, 2015

Yup, perfect and what I expected, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants