Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GrumPHP\Locator\ExternalCommand::locate() does not match interface #60

Closed
aderuwe opened this issue Nov 16, 2015 · 2 comments
Closed

GrumPHP\Locator\ExternalCommand::locate() does not match interface #60

aderuwe opened this issue Nov 16, 2015 · 2 comments
Labels
enhancement

Comments

@aderuwe
Copy link
Contributor

aderuwe commented Nov 16, 2015

See https://github.com/phpro/grumphp/blob/master/src/GrumPHP/Locator/ExternalCommand.php#L40 and https://github.com/phpro/grumphp/blob/master/src/GrumPHP/Locator/LocatorInterface.php#L15
@aderuwe aderuwe changed the title GrumPHP\Locator\ExternalCommand::locate() does not match interface GrumPHP\Locator\ExternalCommand::locate() does not match interface Nov 16, 2015
@veewee
Copy link
Contributor

veewee commented Nov 16, 2015

Additional optional attributes in interfaces are valid in PHP too.
Maybe we should just get rid off the LoctorInterface. It doesn't make much sense since every locator is working in a different way and is returning different data.

What do you think about this?

@aderuwe
Copy link
Contributor Author

aderuwe commented Nov 16, 2015

Yes, I agree. The only common part seems to be the name of the method. :)

@veewee veewee mentioned this issue Dec 1, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aderuwe @veewee