Fatal error thrown when spying on static

[ciaranmcnulty]

This is an invalid case but should be handled better

Spec:

class SpiesExampleSpec extends ObjectBehavior
{
    function it_errors_when_doubling_statics(\DateTime $time)
    {
        $this->getErrorsFromTime($time);

        // getLastErrors is static!
        $time->getLastErrors()->shouldHaveBeenCalled();
    }
}

Object:

class SpiesExample
{
    public function getErrorsFromTime(\DateTime $time)
    {
        $time->getLastErrors();
    }
}

Output:

PHP Fatal error:  Using $this when not in object context in /Users/cmcnulty/spies-error/vendor/phpspec/prophecy/src/Prophecy/Doubler/Generator/ClassCreator.php(49) : eval()'d code on line 17

[ciaranmcnulty]

I guess what I'd like to happen is for prophecy to disallow invoking the message with a sensible error, but I'm not sure if that stops any legitimate use-cases?

[hanneskaeufler]

I just run into this, get the same error. PHP allows us to call static methods from instances of the class and considers this a valid case? See http://php.net/manual/en/language.oop5.static.php. A property declared as static cannot be accessed with an instantiated class object **(though a static method can)**.

This would be useful to be able to inject and Factory type classes.

class FooFactory {
    public static create() { return new Foo(); }
}

class SystemUnderTest {
    public function __construct(FooFactory $factory) {
        // ...
    }

    public function doStuff() {
        $foo = $this->factory->create();
    }
}