Mocked object being sorted raises PHP warning

[braddle]

This bug occurs when calling a mocked function inside a usort function.

The warning is cause by CallCenter::makeCall() calling debug_backtrace() and changing the reference count (http://stackoverflow.com/questions/3235387/usort-array-was-modified-by-the-user-comparison-function)

it is possble to sort mocked objects
      warning: uasort(): Array was modified by the user comparison function in /home/mark/Anobii/pricing_models/src/Sorter.php
      line 20

class Int
{
    public function get()
    {

    }
}

class Sorter
{
    private $prices = [];
    public function addInt(Int $argument1)
    {
        $this->prices[] = $argument1;
    }

    public function sort()
    {
        uasort(
            $this->prices,
            function (Int $a, Int $b) {
                return $a->get() - $b->get();
            }
        );
    }
}

class SorterSpec extends ObjectBehavior
{
    function it_is_initializable()
    {
        $this->shouldHaveType('Ents\Pricing\Model\Sorter');
    }

    function it_is_possble_to_sort_mocked_objects(Int $a, Int $b, Int $c)
    {
        $a->get()->willReturn(1);
        $b->get()->willReturn(4);
        $c->get()->willReturn(2);

        $this->addInt($a);
        $this->addInt($b);
        $this->addInt($c);

        $this->sort();
    }
}

PHP Version: 5.5.21
prophecy Versions: 1.3.1

[stof]

The fact that usort forbids using any debug call or even instantiating exception makes it hardly usable with any other code (especially given that this code cannot know that it is called inside a usort callback, unless it uses one of the features triggering the issue). I suggest you to vote on https://bugs.php.net/bug.php?id=50688. I don't see how we could fix it in Prophecy actually (except by removing features from the library)

[everzet]

Vote on the issue and use @usort in the meantime :/

[mbrodala]

Apparently this was fixed with PHP 7 but not on older versions. I can confirm that @ at least suppresses the warning.

[aik099]

Unfortunately no way to solve this before PHP7, because the mock objects itself tracks how many times each expectation was called and call as part of sort operation increases that counter hence the warning.

I ended up sorting array of object by key, where key value is mocked method value obtained upfront.

[aik099]

Related issue: #215

[mbrodala]

I fell back to plain old PHPUnit mock objects which do not track method calls.