Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The installer doesn't add the generated config to Git #10

Closed
spaze opened this issue Aug 1, 2019 · 2 comments
Closed

The installer doesn't add the generated config to Git #10

spaze opened this issue Aug 1, 2019 · 2 comments

Comments

@spaze
Copy link

spaze commented Aug 1, 2019 •
edited

But that seems to be by design: c36c32c

This causes a bit of a headache when the vendor dir is in Git as the src/GeneratedConfig.php file is .gitignore'd so it's not added, silently.

This should at least be documented (done in #11).
@spaze spaze mentioned this issue Aug 1, 2019
Closed
@ondrejmirtes
Copy link
Member

Fixed by b9f4c4e and released as 1.0.2.

@github-actions
Copy link

github-actions bot commented May 1, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document that the generated config is gitignored
2 participants
@ondrejmirtes @spaze