-
Notifications
You must be signed in to change notification settings - Fork 428
/
CallStaticMethodsRuleTest.php
454 lines (428 loc) · 11.6 KB
/
CallStaticMethodsRuleTest.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
<?php declare(strict_types = 1);
namespace PHPStan\Rules\Methods;
use PHPStan\Php\PhpVersion;
use PHPStan\Rules\ClassCaseSensitivityCheck;
use PHPStan\Rules\FunctionCallParametersCheck;
use PHPStan\Rules\NullsafeCheck;
use PHPStan\Rules\PhpDoc\UnresolvableTypeHelper;
use PHPStan\Rules\RuleLevelHelper;
/**
* @extends \PHPStan\Testing\RuleTestCase<CallStaticMethodsRule>
*/
class CallStaticMethodsRuleTest extends \PHPStan\Testing\RuleTestCase
{
/** @var bool */
private $checkThisOnly;
protected function getRule(): \PHPStan\Rules\Rule
{
$broker = $this->createReflectionProvider();
$ruleLevelHelper = new RuleLevelHelper($broker, true, $this->checkThisOnly, true, false);
return new CallStaticMethodsRule(
$broker,
new FunctionCallParametersCheck($ruleLevelHelper, new NullsafeCheck(), new PhpVersion(80000), new UnresolvableTypeHelper(true), true, true, true, true, true),
$ruleLevelHelper,
new ClassCaseSensitivityCheck($broker),
true,
true
);
}
public function testCallStaticMethods(): void
{
if (!self::$useStaticReflectionProvider && PHP_VERSION_ID >= 70400) {
$this->markTestSkipped('Test does not run on PHP 7.4 because of referencing parent:: without parent class.');
}
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/call-static-methods.php'], [
[
'Call to an undefined static method CallStaticMethods\Foo::bar().',
39,
],
[
'Call to an undefined static method CallStaticMethods\Bar::bar().',
40,
],
[
'Call to an undefined static method CallStaticMethods\Foo::bar().',
41,
],
[
'Static call to instance method CallStaticMethods\Foo::loremIpsum().',
42,
],
[
'Call to private static method dolor() of class CallStaticMethods\Foo.',
43,
],
[
'CallStaticMethods\Ipsum::ipsumTest() calls parent::lorem() but CallStaticMethods\Ipsum does not extend any class.',
63,
],
[
'Static method CallStaticMethods\Foo::test() invoked with 1 parameter, 0 required.',
65,
],
[
'Call to protected static method baz() of class CallStaticMethods\Foo.',
66,
],
[
'Call to static method loremIpsum() on an unknown class CallStaticMethods\UnknownStaticMethodClass.',
67,
'Learn more at https://phpstan.org/user-guide/discovering-symbols',
],
[
'Call to private method __construct() of class CallStaticMethods\ClassWithConstructor.',
87,
],
[
'Method CallStaticMethods\ClassWithConstructor::__construct() invoked with 0 parameters, 1 required.',
87,
],
[
'Calling self::someStaticMethod() outside of class scope.',
93,
],
[
'Calling static::someStaticMethod() outside of class scope.',
94,
],
[
'Calling parent::someStaticMethod() outside of class scope.',
95,
],
[
'Call to protected static method baz() of class CallStaticMethods\Foo.',
97,
],
[
'Call to an undefined static method CallStaticMethods\Foo::bar().',
98,
],
[
'Static call to instance method CallStaticMethods\Foo::loremIpsum().',
99,
],
[
'Call to private static method dolor() of class CallStaticMethods\Foo.',
100,
],
[
'Static method Locale::getDisplayLanguage() invoked with 3 parameters, 1-2 required.',
104,
],
[
'Static method CallStaticMethods\Foo::test() invoked with 3 parameters, 0 required.',
115,
],
[
'Cannot call static method foo() on int|string.',
120,
],
[
'Class CallStaticMethods\Foo referenced with incorrect case: CallStaticMethods\FOO.',
127,
],
[
'Call to an undefined static method CallStaticMethods\Foo::unknownMethod().',
127,
],
[
'Class CallStaticMethods\Foo referenced with incorrect case: CallStaticMethods\FOO.',
128,
],
[
'Static call to instance method CallStaticMethods\Foo::loremIpsum().',
128,
],
[
'Class CallStaticMethods\Foo referenced with incorrect case: CallStaticMethods\FOO.',
129,
],
[
'Call to private static method dolor() of class CallStaticMethods\Foo.',
129,
],
[
'Class CallStaticMethods\Foo referenced with incorrect case: CallStaticMethods\FOO.',
130,
],
[
'Static method CallStaticMethods\Foo::test() invoked with 3 parameters, 0 required.',
130,
],
[
'Class CallStaticMethods\Foo referenced with incorrect case: CallStaticMethods\FOO.',
131,
],
[
'Call to static method CallStaticMethods\Foo::test() with incorrect case: TEST',
131,
],
[
'Class CallStaticMethods\Foo referenced with incorrect case: CallStaticMethods\FOO.',
132,
],
[
'Call to an undefined static method CallStaticMethods\Foo::__construct().',
144,
],
[
'Call to an undefined static method CallStaticMethods\Foo::nonexistent().',
154,
],
[
'Call to an undefined static method CallStaticMethods\Foo::nonexistent().',
159,
],
[
'Static call to instance method CallStaticMethods\Foo::loremIpsum().',
160,
],
[
'Static method CallStaticMethods\ClassOrString::calledMethod() invoked with 1 parameter, 0 required.',
173,
],
[
'Cannot call abstract static method CallStaticMethods\InterfaceWithStaticMethod::doFoo().',
208,
],
[
'Call to an undefined static method CallStaticMethods\InterfaceWithStaticMethod::doBar().',
209,
],
[
'Static call to instance method CallStaticMethods\InterfaceWithStaticMethod::doInstanceFoo().',
212,
],
[
'Static call to instance method CallStaticMethods\InterfaceWithStaticMethod::doInstanceFoo().',
213,
],
[
'Static method CallStaticMethods\Foo::test() invoked with 3 parameters, 0 required.',
298,
],
[
'Call to an undefined static method T of CallStaticMethods\Foo::nonexistentMethod().',
299,
],
[
'Static method CallStaticMethods\Foo::test() invoked with 3 parameters, 0 required.',
302,
],
[
'Call to an undefined static method CallStaticMethods\Foo::nonexistentMethod().',
303,
],
[
'Call to static method doFoo() on an unknown class CallStaticMethods\TraitWithStaticMethod.',
328,
'Learn more at https://phpstan.org/user-guide/discovering-symbols',
],
[
'Call to an undefined static method static(CallStaticMethods\CallWithStatic)::nonexistent().',
344,
],
]);
}
public function testCallInterfaceMethods(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/call-interface-methods.php'], [
[
'Cannot call abstract static method InterfaceMethods\Foo::fooStaticMethod().',
26,
],
[
'Call to an undefined static method InterfaceMethods\Baz::barStaticMethod().',
27,
],
]);
}
public function testCallToIncorrectCaseMethodName(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/incorrect-static-method-case.php'], [
[
'Call to static method IncorrectStaticMethodCase\Foo::fooBar() with incorrect case: foobar',
10,
],
]);
}
public function testStaticCallsToInstanceMethods(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/static-calls-to-instance-methods.php'], [
[
'Static call to instance method StaticCallsToInstanceMethods\Foo::doFoo().',
10,
],
[
'Static call to instance method StaticCallsToInstanceMethods\Bar::doBar().',
16,
],
[
'Static call to instance method StaticCallsToInstanceMethods\Foo::doFoo().',
36,
],
[
'Call to method StaticCallsToInstanceMethods\Foo::doFoo() with incorrect case: dofoo',
42,
],
[
'Method StaticCallsToInstanceMethods\Foo::doFoo() invoked with 1 parameter, 0 required.',
43,
],
[
'Call to private method doPrivateFoo() of class StaticCallsToInstanceMethods\Foo.',
45,
],
[
'Method StaticCallsToInstanceMethods\Foo::doFoo() invoked with 1 parameter, 0 required.',
48,
],
]);
}
public function testStaticCallOnExpression(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/static-call-on-expression.php'], [
[
'Call to an undefined static method StaticCallOnExpression\Foo::doBar().',
16,
],
]);
}
public function testStaticCallOnExpressionWithCheckDisabled(): void
{
$this->checkThisOnly = true;
$this->analyse([__DIR__ . '/data/static-call-on-expression.php'], []);
}
public function testReturnStatic(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/return-static-static-method.php'], [
[
'Call to an undefined static method ReturnStaticStaticMethod\Bar::doBaz().',
24,
],
]);
}
public function testCallParentAbstractMethod(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/call-parent-abstract-method.php'], [
[
'Cannot call abstract method CallParentAbstractMethod\Baz::uninstall().',
21,
],
[
'Cannot call abstract method CallParentAbstractMethod\Lorem::doFoo().',
38,
],
[
'Cannot call abstract method CallParentAbstractMethod\Lorem::doFoo().',
48,
],
[
'Cannot call abstract static method CallParentAbstractMethod\SitAmet::doFoo().',
61,
],
]);
}
public function testClassExists(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/static-methods-class-exists.php'], []);
}
public function testBug3448(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/bug-3448.php'], [
[
'Parameter #1 $lall of static method Bug3448\Foo::add() expects int, string given.',
21,
],
[
'Parameter #1 $lall of static method Bug3448\Foo::add() expects int, string given.',
22,
],
]);
}
public function testBug3641(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/bug-3641.php'], [
[
'Static method Bug3641\Foo::bar() invoked with 1 parameter, 0 required.',
32,
],
]);
}
public function testBug2164(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/bug-2164.php'], [
[
'Parameter #1 $arg of static method Bug2164\A::staticTest() expects static(Bug2164\B)|string, Bug2164\B|string given.',
24,
],
]);
}
public function testNamedArguments(): void
{
if (PHP_VERSION_ID < 80000 && !self::$useStaticReflectionProvider) {
$this->markTestSkipped('Test requires PHP 8.0.');
}
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/static-method-named-arguments.php'], [
[
'Missing parameter $j (int) in call to static method StaticMethodNamedArguments\Foo::doFoo().',
15,
],
[
'Unknown parameter $z in call to static method StaticMethodNamedArguments\Foo::doFoo().',
16,
],
]);
}
public function testBug577(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/bug-577.php'], []);
}
public function testBug4550(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/bug-4550.php'], [
[
'Parameter #1 $class of static method Bug4550\Test::valuesOf() expects class-string<Person>, string given.',
34,
],
[
'Parameter #1 $class of static method Bug4550\Test::valuesOf() expects class-string<Person>, string given.',
44,
],
]);
}
public function testBug1971(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/bug-1971.php'], [
[
'Parameter #1 $callback of static method Closure::fromCallable() expects callable(): mixed, array(class-string<static(Bug1971\HelloWorld)>, \'sayHello2\') given.',
16,
],
]);
}
public function testBug5259(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/bug-5259.php'], []);
}
public function testBug5536(): void
{
$this->checkThisOnly = false;
$this->analyse([__DIR__ . '/data/bug-5536.php'], []);
}
}