Allow to Assert::isInstanceOf() to work with generic and anonymous class strings
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Jul 4, 2024
axlon
force-pushed
the
fix-issue-183
branch
2 times, most recently
from
1b44114
to
cee8dd4
Compare
axlon
commented
Jul 4, 2024
|
|
||
| Assert::isInstanceOfAny($f, [17, self::class]); | ||
| assertType('PHPStan\Type\WebMozartAssert\TypeTest', $f); | ||
| assertType('object', $f); |
There was a problem hiding this comment.
This is the only type that seems to have gotten less specific, this is because we now always fall back to object when we can't find any class names, so we end up with object|PHPStan\Type\WebMozartAssert\TypeTest which is then further normalized to object.
I don't know how big of a deal this is as this code would fail in runtime (17 not being a valid class name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #183 by adding extra checks for class strings to the type resolvers for
Assert::isInstanceOf(). Before this PR the extension would do nothing if it couldn't find a constant class name, now it will always narrow to at leastobject