Call to function in_array() with arguments *NEVER*...

[CassandraKoenen]

Hi,

recently I got the following phpStan error:
Line 70: Call to function in_array() with arguments *NEVER*, array<int, string> and true will always evaluate to true.

My code is

64        $hash = \md5($key . $value . (int) $isVisible);
65
66        if (true === \in_array($hash, $this->itemMetaHashes, true)) {
67            return;
68        }
69
70        if (true === \in_array($hash, $this->currentMetaHashes, true)) {
71            $this->itemMetaHashes[] = $hash;
72
73            return;
74        }

Both $this->itemMetaHashes and $this->currentMetaHashes are arrays of strings.

When I do a type annotation above the second if-statement, the phpStan error doesn't occur anymore:
/** @var string $hash */

I don't understand why this happens. It looks like phpStan looses the information about the type of $hash during the first if-statement.
Can somebody explain to me why this is the case?

Thanks,
Cassandra

[ondrejmirtes]

Hi, to answer this question, I need a reproduction on phpstan.org, thank you.

[CassandraKoenen]

Hi, unfortunately the error does not reproduce on phpstan.org:
https://phpstan.org/r/029b9e50-8663-4275-b581-c665d5edf2b7

I guess I'll have to ignore that error and put my annotation as described in the question.

[ondrejmirtes]

It has to be reproducible. Feel free to check what are the types of variables leading to the error using PHPStan\dumpType() function and then replicate that on phpstan.org.