[IMP] Some errors could not be put into baseline. Re-run PHPStan and fix them

[cuongmits]

I have 2 classes:

class AbstractService
{
    //...
    protected function logAndThrowException(string $message, array $context = []): void
    {
        $message = sprintf('[ES] Request to server failed with message: %s.', $message);
        $this->logger->error($message, $context);

        throw new AiRequestException($message);
    }
}

and another one:

class GetTagAndStatusOfCommentService extends AbstractService
{
    /**
     * @return array{
     *     status: string,
     *     tag: string
     * }
     */
    public function get(int $id, string $comment): array
    {
        try {
            $data = ...;

            return [
                'status' => $data['approval'] ?? '',
                'tag' => $data['tag'],
            ];
        } catch (Exception $exception) {
            $this->logAndThrowException($exception->getMessage(), [
                'id' => $evaluationEnergyId,
                'comment' => $comment,
            ]);
        }
    }
}

but i got this error message: Method App\Service\GetTagAndStatusOfCommentService::get() should return array<string, string> but return statement is missing. which is not correct. Phpstan cannot recognise exception in the parent class.
Then when i tried to generate the baseline, it's impossible, i got this warning:

[WARNING] Baseline generated with 30 errors.                                                                           
           Some errors could not be put into baseline. Re-run PHPStan and fix them.

I think something we need to improve here.

[ondrejmirtes]

Your logAndThrowException needs to have return type never, or PHPDoc @return never.

[cuongmits]

sry didn't know about that, thank you @ondrejmirtes :)