Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.10.67 release introduced wrong date format return type #10893

Closed
mvorisek opened this issue Apr 17, 2024 · 7 comments
Closed

1.10.67 release introduced wrong date format return type #10893

mvorisek opened this issue Apr 17, 2024 · 7 comments

Comments

@mvorisek
Copy link
Contributor

mvorisek commented Apr 17, 2024

Bug report

introduced by phpstan/phpstan-src#2888

/cc @zonuexe

Code snippet that reproduces the problem

https://phpstan.org/r/f14cc68f-70d5-4415-8cc9-ab701294cd00

Expected output

no error

@zonuexe
Copy link
Contributor

zonuexe commented Apr 17, 2024

I recognized the problem. '000000' is a non-falsy-string, but (int)$nonfalsystring is not a non-zero-int.

This looks like an issue that should be fixed in 1.11.x rather than a quick fix for 1.10.x.

@zonuexe
Copy link
Contributor

zonuexe commented Apr 17, 2024

This issue is fixed by changing AccessoryNonFalsyStringType::toInteger().

@ondrejmirtes
Copy link
Member

Hi, this would be a bugfix relevant for 1.10.x as well.

@zonuexe
Copy link
Contributor

zonuexe commented Apr 17, 2024

Ok, I'll submit a PR for 1.10.x.

@ondrejmirtes
Copy link
Member

Fixed phpstan/phpstan-src#3018

@mvorisek
Copy link
Contributor Author

Can a new 1.10 release be expected?

@staabm
Copy link
Contributor

staabm commented May 12, 2024

A release is planned for tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants