calling static methods using call_user_func

[segy]

Summary of a problem or a feature request

calling static method using call_user_func gives error that it expects callable and is given string / array<int, string>.

Code snippet that reproduces the problem

https://phpstan.org/r/e9f9cd7e41d9a0f4b473d0ec902c762c

Expected output

no error

[integer]

Probably same issue as I found for call_user_func and call_user_func_array:

Code snippet that reproduces the problem

https://phpstan.org/r/32d948199501e310faa5fdcd309ab633

Live example

https://3v4l.org/CI130

[JanTvrdik]

The self / static is intentional, because it does not work reliably.
Neither ['self', 'foo'](); or 'self::foo'() will work, making it unsafe to pass those value to functions which require callable.

See the https://wiki.php.net/rfc/consistent_callables for more details about why self, parent and static shall not be used. Instead use for example [static::class, 'foo']().

[JanTvrdik]

The __callStatic error is also intentional. The method MUST be declared either by @method annotation or by providing MethodsClassReflectionExtension.

[ondrejmirtes]

I plan to add some kind of ExtendedCallableType that will be defined as parameter of call_user_func and call_user_func_array and that will accept these special callables.

[ondrejmirtes]

I'm gonna close this issue if this RFC passes: https://wiki.php.net/rfc/deprecate_partially_supported_callables

[VincentLanglet]

The RFC passed, but I don't think the issue should be closed

The error https://phpstan.org/r/c1ba1e32-2cc0-49bc-9e33-8de4a1c101b3 seems related to this issue, but according to the RFC call_user_func[$class, $getter] is still valid sometimes. For instance

class A {
	public static function get(): int
	{
		return 1;
	}
}


$a = A::class;
$b = 'get';
var_dump([$a, $b]());

[ondrejmirtes]

The RFC has not yet passed as the voting closes on 22nd October.

@VincentLanglet Your issue is unrelated and PHPStan's behaviour is expected here. You have no guarantees that [$class, $getter] is a valid callable as the $getter method might not exist. You need to do this instead: https://phpstan.org/r/52f0c45a-5668-4678-a099-949ff3a935ff

Also note that the example you copied here passes: https://phpstan.org/r/f24c3a2f-e190-49f3-b94e-73a314dcc7e2

[VincentLanglet]

@VincentLanglet Your issue is unrelated and PHPStan's behaviour is expected here. You have no guarantees that [$class, $getter] is a valid callable as the $getter method might not exist. You need to do this instead: https://phpstan.org/r/52f0c45a-5668-4678-a099-949ff3a935ff

I see, my bad and thanks.

[phpstan-bot]

@VincentLanglet After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 PHP 8.0 (1 error)
 ==========
 
-10: Parameter #1 $callback of function call_user_func expects callable(): mixed, array(class-string, string) given.
+10: Parameter #1 $callback of function call_user_func expects callable(): mixed, array{class-string, string} given.
 
 PHP 7.1 – 7.4 (1 error)
 ==========
 
-10: Parameter #1 $function of function call_user_func expects callable(): mixed, array(class-string, string) given.
+10: Parameter #1 $function of function call_user_func expects callable(): mixed, array{class-string, string} given.

Full report

PHP 8.0 (1 error)

Line	Error
10	Parameter #1 $callback of function call_user_func expects callable(): mixed, array{class-string, string} given.

PHP 7.1 – 7.4 (1 error)

Line	Error
10	Parameter #1 $function of function call_user_func expects callable(): mixed, array{class-string, string} given.

[ondrejmirtes]

The RFC passed.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.