Invalid error for float type check using 0

[rimvislt]

Summary of a problem or a feature request

Using 0 as default parameter for float type argument gives error:
Default value of the parameter #1 xx of method nn is incompatible with type float.

Code snippet that reproduces the problem

public function test2(float $test2 = 0): void { //}
https://phpstan.org/r/83d22916-c7a8-4bc3-8d37-27b361326329

Expected output

No error

[mpesari]

Just ran into this and wanted to share this case where it doesn't occur with a method coming from a trait. Maybe it's helpful.. or not..

https://phpstan.org/r/88fa77d4-6c83-4066-87d7-67e1c8762cb5

[ondrejmirtes]

Traits in playground behave in a weird way. When running locally, both occurences are reported.

[dktapps]

A generalized blacklist regex I use for this bug:
message: "#^Default value of the parameter \\#\\d+ \\$[A-Za-z\\d_]+ \\(\\-?\\d+\\) of method .+\\(\\) is incompatible with type float\\.$#"

Maybe someone else will find it useful.

[VincentLanglet]

Why not using ?

public function test2(float $test2 = 0.0): void { //}

[dktapps]

It can be done, but when there are hundreds of places in your code where an integer literal is used, it's not very appealing to change them all because of a small bug in a static analyser.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@a5beb06

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.