earlyTerminatingMethodCalls does not recognize methods from interfaces

[mpesari]

Summary of a problem or a feature request

I have an interface with a method that terminates the script. PHPStan handles this differently from a class with a plain terminating method (the latter works just fine.)

Code snippet that reproduces the problem

phpstan.neon:

parameters:
  earlyTerminatingMethodCalls:
    InterfaceWithTerminatingMethod:
      - terminate
    AnotherClassWithTerminatingMethod:
      - terminate

autoload.php:

<?php

interface InterfaceWithTerminatingMethod {
  public static function terminate(): void;
}

class ClassImplementingTerminatingMethod implements InterfaceWithTerminatingMethod {
  public static function terminate(): void {
    exit;
  }
}

class AnotherClassWithTerminatingMethod {
  public static function terminate(): void {
    exit;
  }
}

test.php:

<?php

try {
  $hello = 'Do something that might throw';
  throw new Exception;
} catch (Exception $e) {
  // AnotherClassWithTerminatingMethod::terminate(); // this works
  ClassImplementingTerminatingMethod::terminate();
}

var_dump($hello); // error

$ phpstan analyse -l 7 -c phpstan.neon -a autoload.php test.php
 ------ --------------------------------------- 
  Line   test.php                               
 ------ --------------------------------------- 
  11     Variable $hello might not be defined.  
 ------ --------------------------------------- 

Expected output

I assume PHPStan should recognize early terminating methods even if they come from an interface.

[ondrejmirtes]

Hi,
try latest dev-master if it helps: 24ce5a5