Invalid return type error for interface and class methods with return $this

[ADmad]

Bug report

Since phpstan 0.11.10 the code example below generates error like:

Method X\C::setFoo() should return $this(X\I) but returns $this(X\C)

Code snippet that reproduces the problem

<?php declare(strict_types = 1);
namespace X;

interface I
{
	/**
	 * @param string $p
	 * @return $this
	 */
	public function setFoo(string $p);
}

class C implements I
{
	/**
	 * @inheritDoc
	 */
	public function setFoo(string $p)
	{
		return $this;
	}
}

Expected output

No errors.

I am unable to reproduce the issue on https://phpstan.org. Is it using the latest phpstan version?

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.
It will most likely be closed after manual review.

[ondrejmirtes]

This is fixed on master, not in 0.11.x. That's why you can't reproduce it. 0.11.10 added support for @inheritDoc. Before it didn't see the typehint at all.

[ADmad]

Okay thanks. Would be a good idea to show the phpstan version number on PHPStan playground.

[ADmad]

Will the issue be fixed in next 0.11.x release?

[ondrejmirtes]

No, I've taken advantage of some refactoring to do the fix, that's why it's not in 0.11.x. Sorry.

[ADmad]

That's quite unfortunate. This bug shows 34 invalid errors in our CakePHP codebase and now someone has to spend time ignoring them through phpstan.neon.

[ondrejmirtes]

@ADmad OK, I will backport the fix, it might not be that hard. Please stay tuned, I'll do it ASAP.

[ondrejmirtes]

Please test 0.11.12@dev (or something like that) if it works. It's commit 56b3eb2.

[ADmad]

It works! Thank you very much.

[ondrejmirtes]

I just tagged 0.11.12 :)