False positive: constant in abstract class

[tbmatuka]

Bug report

phpstan considers $this::CONSTANT the same as self::CONSTANT, which it shouldn't.

Code snippet that reproduces the problem

https://phpstan.org/r/f9cd163f-bcf1-4547-b332-264c94aebb5c

Expected output

$this::CONSTANT in a non-final class (and especially an abstract one) should not be considered as the value that it is set to in the current class.

Usecase

I'm using doctrine and I have an abstract repository class that I extend for all of my repositories. To avoid duplicating the constructor, I set a constant to the entity class name and use it in the constructor. This gives me a single clean line of code at the beginning of the class to make it work.

Temporary workaround

I created a function in the abstract class that returns $this::CONSTANT and used the result of that in the constructor. It's ugly, but it avoids triggering the bug.

[ondrejmirtes]

You can use static::CONSTANT today for the same effect.

[tbmatuka]

@ondrejmirtes you're right, that's a lot better solution for my code! I guess I should stop using $this:: anyway, so that will work for me in the future. Thanks for your help.

[phpstan-bot]

@tbmatuka PHPStan now reports different result with your code snippet:

@@ @@
+No errors
+
+PHP 7.1 – 7.3 (1 error)
+==========
+
 12: Strict comparison using === between '' and '' will always evaluate to true.

Full report

PHP 7.4 – 8.0

No errors

PHP 7.1 – 7.3 (1 error)

Line	Error
12	Strict comparison using === between '' and '' will always evaluate to true.

[phpstan-bot]

@tbmatuka After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-12: Strict comparison using === between '' and '' will always evaluate to true.
+No errors

[ondrejmirtes]

Fixed: phpstan/phpstan-src@4cb02d1

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.