Incorrect errors after upgrading to 0.12.9 for php-decimal extension and stub

[maks-rafalko]

Bug report

Code snippet that reproduces the problem

new Decimal(0);

Expected output (0.12.8)

no issue

Actual output (0.12.9)

Parameter #1 $value of class Decimal\Decimal constructor expects string, int given.

We are using stubs for Decimal\Decimal class, and it allows int:

https://github.com/php-decimal/stubs/blob/683b5c68b13c14373df9e835f98926c62c73c29d/Decimal.php#L30

I'm not sure PHPStan used this stub file before, or started using it after 0.12.9, but something has changed ;)

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.
It will most likely be closed after manual review.

[maks-rafalko]

This bug report is missing a link to reproduction on phpstan.org.

playground does not have needed extension, not applicable

[ondrejmirtes]

Hi, do you mean PHPStan 0.12.29? It's reproducible in the playground (the loaded PHP extensions aren't necessary anymore): https://phpstan.org/r/3cafdef6-97f4-4bfc-93d2-3af9e82ad808

[ondrejmirtes]

Sent a PR upstream: JetBrains/phpstorm-stubs#838

[ondrejmirtes]

Please try dev-master of phpstan/phpstan to see if there are any more problems related to Decimal. This one is fixed:

Thank you.

[ondrejmirtes]

Forgot the link: https://phpstan.org/r/d84eb611-2b18-4df8-a8f9-57985ed909a4

[maks-rafalko]

Hi, do you mean PHPStan 0.12.29

yes, sorry, 0.12.29

Thanks!

[ondrejmirtes]

Just PHPStan as it already depends on dev-master of phpstorm-stubs.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.