Using @phpstan-ignore-line after already ignored line fails

[davidbrnovjak]

Bug report

Trying to ignore one line in code with @phpstan-ignore-line fails if previous line was already marked to ignore.

Code snippet that reproduces the problem

Using two @phpstan-ignore-line doesn’t work
https://phpstan.org/r/fbb053a0-9a30-4167-8385-cee47c509f9e

Using @phpstan-ignore-line after @phpstan-ignore-next-line doesn’t work either
https://phpstan.org/r/b73c58e0-22df-4e54-80c4-27311e7a091b

But using @phpstan-ignore-next-line works
https://phpstan.org/r/ebc7d3f9-d031-4793-8fb6-35e8564df7c1

Bug or feature? :)

Expected output

Both lines should be ignored

[phpstan-bot]

@davidbrnovjak After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 6: Else branch is unreachable because ternary operator condition is always true.
-6: Strict comparison using !== between array() and false will always evaluate to true.
+6: Strict comparison using !== between array{} and false will always evaluate to true.

Full report

Line	Error
6	Else branch is unreachable because ternary operator condition is always true.
6	Strict comparison using !== between array{} and false will always evaluate to true.

[phpstan-bot]

@davidbrnovjak After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 7: Else branch is unreachable because ternary operator condition is always true.
-7: Strict comparison using !== between array() and false will always evaluate to true.
+7: Strict comparison using !== between array{} and false will always evaluate to true.

Full report

Line	Error
7	Else branch is unreachable because ternary operator condition is always true.
7	Strict comparison using !== between array{} and false will always evaluate to true.

[canvural]

Is it possible that this is PHP-Parser bug?

The Arg node on line 5 does not have comments in attributes. The second Arg node has but the line number is 5.

Also in the above case, none of the nodes have comments attribute.

Shorter code to reproduce:

<?php

array_merge(
	[], // First comment
  	[], // Second comment
);

[ondrejmirtes]

@canvural Yeah, Nikita told me to read the comments directly from tokens: nikic/PHP-Parser#742

[canvural]

nikic/PHP-Parser#791 maybe.

[phpstan-bot]

@davidbrnovjak After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-6: Else branch is unreachable because ternary operator condition is always true.
-6: Strict comparison using !== between array() and false will always evaluate to true.
+No errors

[phpstan-bot]

@davidbrnovjak After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-7: Else branch is unreachable because ternary operator condition is always true.
-7: Strict comparison using !== between array() and false will always evaluate to true.
+No errors

[ondrejmirtes]

Fixed: phpstan/phpstan-src@9474696

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.