Call to function array_key_exists() with int and array will always evaluate to true

[ossinkine]

Bug report

False-positive alerts when using array_key_exists function.

Code snippet that reproduces the problem

https://phpstan.org/r/ce4a9861-014d-4ccc-84db-0e8d9ab47e34

Expected output

Expecting no alerts

[ossinkine]

@ondrejmirtes Please help me find where the error is, which class look at

[szepeviktor]

Maybe https://github.com/phpstan/phpstan-src/blob/e96481c3210c9aa93de45f482c11789c1face65d/src/Type/Php/ArrayKeyExistsFunctionTypeSpecifyingExtension.php#L46-L61

[ondrejmirtes]

@ossinkine Check what's $foo here on line 14: https://phpstan.org/r/c44956e6-9bf4-4ae7-ac52-4f8c62579a38

I suspect it will be something like array&hasOffset(int) but that doesn't mean that any int is present there...

This error message comes from this class - https://github.com/phpstan/phpstan-src/blob/master/src/Rules/Comparison/ImpossibleCheckTypeHelper.php - if it returns true, it's always true, if it returns false, it's always false, if it returns null, nothing is reported.

So you can see for yourself what types are compared with isSuperTypeOf in this branch https://github.com/phpstan/phpstan-src/blob/e96481c3210c9aa93de45f482c11789c1face65d/src/Rules/Comparison/ImpossibleCheckTypeHelper.php#L173-L195 and if the result of isSuperTypeOf between those types makes sense or not.

[ossinkine]

@ondrejmirtes Unfortunatelly I could not figure out with this. The code you pointed is executed 5 times in my test, $foo has the intersect of the following types:

1. ArrayType and HasOffsetType with offset type ConstantIntegerType with value 1
2. ArrayType and HasOffsetType with offset type ConstantIntegerType with value 2
3. ArrayType and HasOffsetType with offset type UnionType of ConstantIntegerType with value 1 and ConstantIntegerType with value 2
4. ArrayType and HasOffsetType with offset type UnionType of ConstantIntegerType with value 2 and ConstantIntegerType with value 3
5. ArrayType and HasOffsetType with offset type IntegerType

As a result the array has any integer offset what should be wrong but I don't how to fix this.

[phpstan-bot]

@ossinkine After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-14: Call to function array_key_exists() with int and array will always evaluate to true.
+No errors

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-15: Call to function array_key_exists() with int and array will always evaluate to true.
+No errors

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.