Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use phpstan.dist.neon instead of phpstan.neon.dist for IDE-friendly #3869

Closed
Luc45 opened this issue Sep 14, 2020 · 4 comments
Closed

Comments

@Luc45
Copy link

Luc45 commented Sep 14, 2020

Feature request

With the current file naming convention, the extension of the file phpstan.neon.dist is .dist, which causes IDEs such as PHPStorm to not recognize it as a .neon file, even with the Neon plugin installed.

If, however, the file was phpstan.dist.neon, the extension would be .neon and IDEs would pick it up as a Neon file.

This feature request is to allow support for a file named phpstan.dist.neon for distributed phpstan configurations.

Thanks

@ondrejmirtes
Copy link
Member

Hi, this is just a convention following PHPUnit's phpunit.xml + phpunit.xml.dist. Feel free to name your files whatever you want, you just have to pass it as -c CLI option manually :) If you involve Composer scripts, or make, or Phing for example, you don't have to type the whole command all the time, but only for example make phpstan...

@Luc45
Copy link
Author

Luc45 commented Sep 14, 2020

Hi @ondrejmirtes ,

That's exactly what I do: I have a make phpstan command that overrides -c phpstan.dist.neon

However, I loose the cascading override to phpstan.neon for the local environment - and that's the downside of this approach

@ondrejmirtes
Copy link
Member

Hi, if you persuade PHPUnit's maintainers about this then I'm sold on this too but I don't want to make this change alone.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants