Strict comparison using === between 4 and 4 will always evaluate to true.

[SergeC]

Bug report

I have a code in my project like in case1 in a code sample which triggers the following error. In case2 is the same code snippet with sorted elseif branches.

Code snippet that reproduces the problem

https://phpstan.org/r/1b70ab7b-24e9-4507-bb77-c175607bf78f

Expected output

The case1 example must work without an error.

[SergeC]

The case1 will not trigger any errors if following branch removed:

else {
		return;
		}

[ondrejmirtes]

Both of the examples should report an error. Here are the inferred types: https://phpstan.org/r/74a325e0-0502-44d8-b536-5b348d14ec97

I don't know why the in_array() call on line 105 does not report an error, but it should.

If you're not interested in "always true" errors, you can turn them off. Either by stopping using phpstan-strict-rules, or by setting these settings off: https://phpstan.org/config-reference#checkalwaystruechecktypefunctioncall

[SergeC]

@ondrejmirtes Can you please provide more details on why both cases should report an error and how it works? I believe there is no always true condition. The $data->getType() statement always returns 1 since it passed with construct $data=(new Data(Enum::TYPE_A));. In your example the last \PHPStan\dumpType($data->getType()); statement returns Dumped type: 7|8|9|100 but $data->getType() always returns 1.

[ondrejmirtes]

@SergeC The method is annotated as getType(): int. There's no generics involved.

[phpstan-bot]

@SergeC After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-62: Strict comparison using === between 4 and 4 will always evaluate to true.
+-1: Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40
+Run PHPStan with --debug option and post the stack trace to:
+https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

Full report

Line

Error

-1

Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40Run PHPStan with --debug option and post the stack trace to:https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
- 53: Dumped type: 1|2|3|4|7|8|9|100
- 63: Strict comparison using === between 4 and 4 will always evaluate to true.
- 86: Dumped type: 1|2|3|4|7|8|9|100
-103: Dumped type: 7|8|9|100
+ -1: Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40
+Run PHPStan with --debug option and post the stack trace to:
+https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

Full report

Line

Error

-1

Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40Run PHPStan with --debug option and post the stack trace to:https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.