Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-abstract method without body in non-interface not considered an error #4244

Closed
dktapps opened this issue Dec 16, 2020 · 3 comments
Closed

Non-abstract method without body in non-interface not considered an error #4244

dktapps opened this issue Dec 16, 2020 · 3 comments
Labels
feature-request
Milestone
Static reflection

Comments

@dktapps
Copy link
Contributor

dktapps commented Dec 16, 2020

Bug report

Code snippet that reproduces the problem

https://phpstan.org/r/237aeeea-6aec-4661-882b-51913e6dabfe

Expected output

An error should be reported because the method does not declare an abstract modifier and doesn't belong to an interface.
@ondrejmirtes ondrejmirtes added this to the Static reflection milestone Dec 16, 2020
@dktapps
Copy link
Contributor Author

dktapps commented May 23, 2022

I think this is more relevant now after 1.7.0 release.

@paulbalandan paulbalandan mentioned this issue Nov 13, 2023
Merged
@ondrejmirtes
Copy link
Member

Implemented: phpstan/phpstan-src#2730

@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
Static reflection
Development

No branches or pull requests
2 participants
@ondrejmirtes @dktapps