@phpstan-ignore-line do not work in chained setters

[Eimantas123]

Bug report

@phpstan-ignore-line do not work in setters when after ignored line there are more chained setters.

Code snippet that reproduces the problem

https://phpstan.org/r/5e363ac1-aebb-4ab6-8d8c-ed2f896ee088

Expected output

no error because we use // @phpstan-ignore-line

[ondrejmirtes]

Reported upstream: nikic/PHP-Parser#742

[mvorisek]

also, call to undefined method warning is rendered with wrong line: https://phpstan.org/r/b4bd2d03-7465-4b32-b731-895522112f57

quite important as chanined method calls are very often on separate lines

[digilist]

I have a similar issue with function arguments:

function sayHello(DateTimeInterface $date): void {}

sayHello(
	new stdClass /* @phpstan-ignore-line */ 
);


sayHello(
	/* @phpstan-ignore-line */ new stdClass 
);

Only the second error is suppressed: https://phpstan.org/r/f19a1c5d-44eb-4f25-bb44-b5126fe29b0a

I would guess this is related?

[phpstan-bot]

@Eimantas123 After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
+ 7: Property AwesomeFeature::$variable is never read, only written.
 35: Parameter #1 $variable of method AwesomeFeature::setVariable() expects string, string|null given.

Full report

Line	Error
7	Property AwesomeFeature::$variable is never read, only written.
35	`Parameter #1 $variable of method AwesomeFeature::setVariable() expects string, string

[phpstan-bot]

@mvorisek After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
+ 7: Property AwesomeFeature::$variable is never read, only written.
 34: Call to an undefined method AwesomeFeature::doSmthd().
 35: Parameter #1 $variable of method AwesomeFeature::setVariable() expects string, string|null given.

Full report

Line	Error
7	Property AwesomeFeature::$variable is never read, only written.
34	Call to an undefined method AwesomeFeature::doSmthd().
35	`Parameter #1 $variable of method AwesomeFeature::setVariable() expects string, string

[phpstan-bot]

@Eimantas123 After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
+ 7: Property AwesomeFeature::$variable is never read, only written.
 35: Parameter #1 $variable of method AwesomeFeature::setVariable() expects string, string|null given.

Full report

Line	Error
7	Property AwesomeFeature::$variable is never read, only written.
35	`Parameter #1 $variable of method AwesomeFeature::setVariable() expects string, string

[phpstan-bot]

@mvorisek After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
+ 7: Property AwesomeFeature::$variable is never read, only written.
 34: Call to an undefined method AwesomeFeature::doSmthd().
 35: Parameter #1 $variable of method AwesomeFeature::setVariable() expects string, string|null given.

Full report

Line	Error
7	Property AwesomeFeature::$variable is never read, only written.
34	Call to an undefined method AwesomeFeature::doSmthd().
35	`Parameter #1 $variable of method AwesomeFeature::setVariable() expects string, string

[phpstan-bot]

@Eimantas123 After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-35: Parameter #1 $variable of method AwesomeFeature::setVariable() expects string, string|null given.
+ 7: Property AwesomeFeature::$variable is never read, only written.

Full report

Line	Error
7	Property AwesomeFeature::$variable is never read, only written.

[phpstan-bot]

@mvorisek After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-34: Call to an undefined method AwesomeFeature::doSmthd().
-35: Parameter #1 $variable of method AwesomeFeature::setVariable() expects string, string|null given.
+ 7: Property AwesomeFeature::$variable is never read, only written.
+34: Call to an undefined method AwesomeFeature::doSmthd().

Full report

Line	Error
7	Property AwesomeFeature::$variable is never read, only written.
34	Call to an undefined method AwesomeFeature::doSmthd().

[phpstan-bot]

@digilist After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-6: Parameter #1 $date of function sayHello expects DateTimeInterface, stdClass given.
+No errors

[ondrejmirtes]

Fixed: phpstan/phpstan-src@9474696

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.