Iterating over type with static

[ondrejmirtes]

Bug report

Originally reported: #4220

Both versions with generics and without generics should work.

It might just be a matter of modifying ObjectType::getIterableValueType(), to resolve the StaticType (similar to this https://github.com/phpstan/phpstan-src/blob/19bf582aa3c0e0809446a17399d17d17ab40297c/src/Analyser/MutatingScope.php#L4515-L4526).

Code snippet that reproduces the problem

• https://phpstan.org/r/f462b4b3-ba01-44e1-a68a-b157e9bd8621
• https://phpstan.org/r/39783e69-bcfd-426f-b9f9-48f5806e37e2

Expected output

Correctly resolved $h to HelloWorld.

[mvorisek]

more details on how to fix: #4220 (reply in thread)

[mvorisek]

@ondrejmirtes I was able to fix it with this patch: https://github.com/mvorisek/atk4-hintable-mirror/blob/1.1.5/patch-phpstan-static-type-issue-4267.php

here is the patch in an action: https://github.com/atk4/data/pull/821/files

fix for src/Type/ObjectType.php seems more or less legit, fix for is what I proposed in phpstan/phpstan-src#414, please help with fixing this issue officially, I do not have a deep knowledge of phpstan internals

[ondrejmirtes]

please help with fixing this issue officially

I filed this issue among hundreds other bug reports and feature requests, please adjust your expectations accordingly. It can take some time before I think of this as a priority. I consider this https://phpstan.org/r/9829582c-f3a5-48e4-ae43-d43d709e8282 a very good workaround.

[mvorisek]

Model in atk4/data is a base model for all user's models used by thousands of users worldwide. As per average project there are a lot of different Model classes, this workaround is not possible.

The phpstan patch I released fixes this issue, but of course it is a fragile/short term solution.

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-24: Access to an undefined property Model::$x.
+No errors

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
- 3: Class Model implements generic interface IteratorAggregate but does not specify its types: TKey, TValue
-21: Access to an undefined property Model::$x.
+ 3: Class Model implements generic interface IteratorAggregate but does not specify its types: TKey, TValue

Full report

Line	Error
3	Class Model implements generic interface IteratorAggregate but does not specify its types: TKey, TValue

[ondrejmirtes]

This frikking thing took me 3 days to figure out... phpstan/phpstan-src#474

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.