After upgrade to 0.12.78

[dakorpar]

Bug report

After upgrading to 0.12.78 looks like

	if ($classType->isSubclassOf(BaseRequest::class)) {
		$request = $classType->newInstance();

$request is being recognized as object instead of BaseRequest,

159 Call to an undefined method object::whatever().

works well on 0.12.77 and does not report this error.

Code snippet that reproduces the problem

	if ($classType->isSubclassOf(BaseRequest::class)) {
		$request = $classType->newInstance();
		request->whatever();

	}

https://phpstan.org/r/e1fc69b5-0542-4286-9d52-c85234392b07

ignore the first error, second one is problem

Expected output

no issue here

[ondrejmirtes]

Hi, I'm pretty sure this haven't changed in 0.12.78, just verified when running this locally. It's very possible that the type inference got smarter in 0.12.78 and your variable is now of type object instead of mixed for example. One of likely changes to cause this is for example phpstan/phpstan-src@0f64ca7 or phpstan/phpstan-src@bf320b0.

Can you provide a piece of code that you verify locally passing on 0.12.77 and failing on 0.12.78?

[ondrejmirtes]

Anyway, I just wrote a little extension that makes PHPStan understand this code anyway: phpstan/phpstan-src@d3b5d60

[dakorpar]

@ondrejmirtes I actually runned phpstan on 0.12.77 and 0.12.78 it threw error only on 0.12.78.
However maybe it is because before it recognized var as mixed.
Thanks!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.