Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subsequent // @phpstan-ignore-line is ignored / without effect #4750

Closed
jtopenpetition opened this issue Mar 25, 2021 · 3 comments
Closed

subsequent // @phpstan-ignore-line is ignored / without effect #4750

jtopenpetition opened this issue Mar 25, 2021 · 3 comments
Labels
Milestone

Comments

@jtopenpetition
Copy link

Bug report

in this specific code snippet the // @phpstan-ignore-line doesn't mute the second line's error

Code snippet that reproduces the problem

<?php

return [
	'first' => $first, // @phpstan-ignore-line
	'second' => $second, // @phpstan-ignore-line  <-- this line still produces an error
];

https://phpstan.org/r/8034d53c-c704-4cd5-ac28-b9dac7cd3dff

Expected output

no error

@phpstan-bot
Copy link
Contributor

@jtopenpetition After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-5: Variable $second might not be defined.
+No errors

@ondrejmirtes
Copy link
Member

Fixed: phpstan/phpstan-src@9474696

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants