when 'Else branch is unreachable because previous condition is always true' is not true

[yphoenix]

Bug report

PHPStan - PHP Static Analysis Tool 0.12.84

PHPStan says that the else is unreachable, I say it is.

Code snippet that reproduces the problem

https://phpstan.org/r/adffe5b9-8174-41b6-a774-b988dbfd0165

Expected output

No warnings

[ondrejmirtes]

The root issue here is that isset($_SESSION) should be bool and not true: https://phpstan.org/r/905e0f11-19d7-42d9-b3c4-b176c21d0aaa

[phpstan-bot]

@yphoenix After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-15: Else branch is unreachable because previous condition is always true.
+No errors

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
- 9: Dumped type: true
-17: Else branch is unreachable because previous condition is always true.
+ 9: Dumped type: bool

Full report

Line	Error
9	Dumped type: bool

[yphoenix]

Thank you.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.