Strict comparison using === between *NEVER* and 'TB' will always evaluate to false.

[danielmarschall]

Bug report

I receive following errors:

  14     Strict comparison using === between *NEVER* and 'TB' will always evaluate to false.  
  15     Strict comparison using === between *NEVER* and 'c' will always evaluate to false.  

Running version 0.12.88 with Level 4+.

Reproduction URL: https://phpstan.org/r/bc0bf93c-2d11-40d9-b050-70dd3494b115

Code snippet that reproduces the problem

function isKnownUOM(string $uom) {
        return (
                ($uom === '') ||
                ($uom === 's') ||
                ($uom === 'ms') ||
                ($uom === 'us') ||
                ($uom === '%') ||
                ($uom === 'B') ||
                ($uom === 'KB') ||
                ($uom === 'MB') ||
                ($uom === 'GB') ||
                ($uom === 'TB') ||
                ($uom === 'c')
        );
}

Expected output

No errors

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.

It will most likely be closed after manual review.

[danielmarschall]

https://phpstan.org/r/bc0bf93c-2d11-40d9-b050-70dd3494b115

[ondrejmirtes]

Duplicate of #3555

[stof]

@ondrejmirtes as this issue is about a case where phpstan infers the constant union, maybe it should keep it as string when reaching the CONSTANT_SCALAR_UNION_THRESHOLD instead of refining the type to a broken one. there is no phpdoc enum involved in that specific case.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

[ondrejmirtes]

I managed to solve this.

• Removed CONSTANT_SCALAR_UNION_THRESHOLD: phpstan/phpstan-src@c56d866
• Optimization of TypeCombinator::union() when a lot of scalars are involved: phpstan/phpstan-src@da9e061

Look forward to the next release (0.12.95) :)