Baseline output is not stable

[mvorisek]

Bug report

Code snippet that reproduces the problem

run on 2 different machines, one linux (CI, multicpu) and one Windows (with 1 CPU)

Expected output

baseline output must always be stable

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.

It will most likely be closed after manual review.

[ondrejmirtes]

/cc @dktapps

[dktapps]

...

To be honest, I was already inclined to point to a change in PHP's own behaviour to blame for this in the first place, considering that the errors were already sorted, and especially now considering the fact that the errors are now sorted immediately before output, first by file, then by message pattern. So if this still didn't fix it, then I'm out of answers.

[dktapps]

On closer inspection, I noticed this: https://github.com/phpstan/phpstan-src/blob/master/src/Command/ErrorFormatter/BaselineNeonErrorFormatter.php#L64

This makes me think that the sorting order change is something to do with the directory separators in the original path (since it would likely be absolute), which might explain the ordering difference. I guess it would make sense to alter the algorithm to sort based on the normalized relative path, instead of the original path.

[ondrejmirtes]

Fixed by phpstan/phpstan-src#536

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.