Incorrectly assuming int has strlen 0 without strict types

[schlndh]

Bug report

Since version 0.12.93 (it does not happen in 0.12.92) phpstan incorrectly assumes that strlen of an integer is 0 when called from a file without declare(strict_types=1). Casting the integer to string fixes the problem.

Code snippet that reproduces the problem

https://phpstan.org/r/29a373ea-907e-44a5-a426-069ce03a5662

Expected output

Comparison operation "<" between 0 and 3 is always true. should not be reported.

[staabm]

I guess needs investigation in https://github.com/phpstan/phpstan-src/blob/e10a7aac373e8b6f21b430034fc693300c2bbb69/src/Type/Php/StrlenFunctionReturnTypeExtension.php#L39

unit test at https://phpstan.org/r/9ca635a2-d11e-4a4c-b733-22d51214166d

[phpstan-bot]

@schlndh After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 7: Comparison operation "<" between 0 and 3 is always true.
-7: Parameter #1 $string of function strlen expects string, int given.
+7: Parameter #1 $string of function strlen expects string, int<0, 10000> given.

Full report

Line	Error
7	Comparison operation "<" between 0 and 3 is always true.
7	Parameter #1 $string of function strlen expects string, int<0, 10000> given.

[phpstan-bot]

@staabm After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 9: Expected type int, actual: 0
-9: Parameter #1 $string of function strlen expects string, int given.
+9: Parameter #1 $string of function strlen expects string, int<0, 10000> given.

Full report

Line	Error
9	Expected type int, actual: 0
9	Parameter #1 $string of function strlen expects string, int<0, 10000> given.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.