Bleeding Edge: Type xxx of property xxx is not the same as type xxx of overridden property

[Dgame]

Bug report

I get the error

Type array<class-string> of property MyHandler::$dontReport is not the same as type array of overridden property Handler::$dontReport.

with bleeding-edge enabled. Link to the Playground.

I'm overriding the property of the lumen error handler so I can't change the parent class. But IMO, since I'm making the type more concrete, this shouldn't be an error in the first place.

Expected output

No error, as we make the type more concrete than it is.

[ondrejmirtes]

Hi, this is expected. Property types can't be covariant/contravariant - they're invariant. This helps you to be protected against the parent class writing something that isn't class-string to the property.

You can fix this issue with stub files: https://phpstan.org/user-guide/stub-files

[Dgame]

In that case, how am I supposed to overwrite third-party library code that expects me to overwrite it but is not phpstan-compatible? I can't - at least not without StubFiles as it seems. But instead, I and probably many others will just write @phpstan-ignore-next-line and that's it. Wouldn't it make more sense to recognise that I'm specifying the type, especially if the parent type is just array? I would understand it if I made int into string, or array<int> into array<string>. Even if it was array<mixed> and I tried to specify it as array<int>. But if it is just array in the parent and I specify it as array<int>, then IMO it should be perfectly fine. I suspect you probably consider array to be an implicit array<mixed>, but I think that is wrong in this case.

[ondrejmirtes]

Yeah, I'll relax those rules a bit, same as method parameters and return types are not enforced fully by default. The strictest variant will be an opt-in via a separate option (and enabled in phpstan-strict-rules).

[ondrejmirtes]

Implemented: phpstan/phpstan-src@24f6264

The rules are relaxed a bit, you should get the stricter version with reportMaybesInPropertyPhpDocTypes: true and/or with phpstan-strict-rules.

There are also included tips in the error messages telling you about this option and stub files.

[Dgame]

Thank you very much!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.