If condition is always true (pass by reference to a callable)

[someonewithpc]

Bug report

/**
 * @param callable(bool &$save): void $call
 */
function get(callable $call) {
    $save = true;
    $call($save);
    if ($save) {
        echo "Save item\n";
    } else {
        echo "Don't save\n";
    }
}

get(function (bool &$save) {}); // Save item
get(function (bool &$save) { $save = false; }); // Don't save

Code snippet that reproduces the problem

https://phpstan.org/r/528c3596-7697-4fe6-810d-3ce01231328c

Expected output

If condition is always true.

This error is a false positive, since the callable takes the bool by reference and might, thus, modify it

Did PHPStan help you today? Did it make you happy in any way?

It's been very helpful, found a bunch of real bugs and improvements :)

[ondrejmirtes]

Thank you for your kind words! :)

Fixed: phpstan/phpstan-src@109bf99

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.