Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modulo '1' is always 0 #5822

Closed
staabm opened this issue Oct 23, 2021 · 2 comments · Fixed by phpstan/phpstan-src#973
Closed

modulo '1' is always 0 #5822

staabm opened this issue Oct 23, 2021 · 2 comments · Fixed by phpstan/phpstan-src#973
Labels
feature-request

Comments

@staabm
Copy link
Contributor

staabm commented Oct 23, 2021

Feature request

like we already do for $x % 1 always results in zero, we should do the same for $x % '1'

https://3v4l.org/hj9dj
https://phpstan.org/r/dfb4fe6e-8a52-4903-9086-67922b846543
@ondrejmirtes
Copy link
Member

I'm sure you can contribute this :)

@staabm staabm mentioned this issue Feb 1, 2022
Merged
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

modulo '1' is always zero staabm/phpstan-src
2 participants
@ondrejmirtes @staabm