Chained nullsafe method call wrongly induces caller's type

[janedbal]

Bug report

See snippet, found while upgrading from 0.12.99 to 1.0.0

Code snippet that reproduces the problem

https://phpstan.org/r/208a06db-9004-4c14-96c1-7f4ad80493da

Expected output

No error.

[olsavmic]

@ondrejmirtes Quick fix would be to move NullsafeOperatorHelper::getNullsafeShortcircuitedExpr back to the ruleLevelHelper->findTypeToCheck (enabling it conditionally, as it was done in https://github.com/phpstan/phpstan-src/pull/687/files/ce98dd8699de590e1585e925cc463ca286f4de58#diff-9dace3387909be6cad5cfedf4087102d316daf48f31a033ae258ab119636035b) since the auto-removal now skips the $scope->moreSpecificTypes record created by NodeScopeResolver for original NullsafeMethodCall.

I was not aware of this part and it's quite hard to wrap head around this logic. Perhaps we could get rid of the NullsafeOperatorHelper by passing the moreSpecificType to nested MethodCalls as well?

[jeroennoten]

Another example that reproduces the problem: https://phpstan.org/r/954e0684-5afd-4c23-bbe5-e9e56d92801d

[olsavmic]

@ondrejmirtes I created a PR with the original "not-ideal but working" solution as I'm pretty sure this bothers many users :/

[ondrejmirtes]

Fixed by: phpstan/phpstan-src#752

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.