ShouldNotHappenException thrown in `pdo->query` DynamicMethodReturnTypeExtension

[staabm]

Bug report

Uncaught PHPStan\ShouldNotHappenException: Internal error. in phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/ParametersAcceptorSelector.php:38
#0 C:\dvl\Workspace\phpstan-dba\src\Extensions\PdoQueryDynamicReturnTypeExtension.php(48): PHPStan\Reflection\ParametersAcceptorSelector::selectSingle()
#1 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(3446): staabm\PHPStanDba\Extensions\PdoQueryDynamicReturnTypeExtension->getTypeFromMethodCall()
#2 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(1676): PHPStan\Analyser\MutatingScope->methodCallReturnType()
#3 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(1682): PHPStan\Analyser\MutatingScope->PHPStan\Analyser\{closure}()
#4 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(511): PHPStan\Analyser\MutatingScope->resolveType()
#5 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(767): PHPStan\Analyser\MutatingScope->getType()
#6 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php(511): PHPStan\Analyser\MutatingScope->resolveType()
#7 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(1348): PHPStan\Analyser\MutatingScope->getType()
#8 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(491): PHPStan\Analyser\NodeScopeResolver->findEarlyTerminatingExpr()
#9 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(293): PHPStan\Analyser\NodeScopeResolver->processStmtNode()
#10 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(455): PHPStan\Analyser\NodeScopeResolver->processStmtNodes()
#11 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(293): PHPStan\Analyser\NodeScopeResolver->processStmtNode()
#12 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(539): PHPStan\Analyser\NodeScopeResolver->processStmtNodes()
#13 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(293): PHPStan\Analyser\NodeScopeResolver->processStmtNode()
#14 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(505): PHPStan\Analyser\NodeScopeResolver->processStmtNodes()
#15 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(264): PHPStan\Analyser\NodeScopeResolver->processStmtNode()
#16 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/FileAnalyser.php(181): PHPStan\Analyser\NodeScopeResolver->processNodes()
#17 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/Analyser.php(69): PHPStan\Analyser\FileAnalyser->analyseFile()
#18 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Command/AnalyserRunner.php(62): PHPStan\Analyser\Analyser->analyse()
#19 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Command/AnalyseApplication.php(163): PHPStan\Command\AnalyserRunner->runAnalyser()
#20 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Command/AnalyseApplication.php(95): PHPStan\Command\AnalyseApplication->runAnalyser()
#21 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/src/Command/AnalyseCommand.php(175): PHPStan\Command\AnalyseApplication->analyse()
#22 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Command/Command.php(259): PHPStan\Command\AnalyseCommand->execute()
#23 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(848): _PHPStan_e04cc8dfb\Symfony\Component\Console\Command\Command->run()
#24 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(259): _PHPStan_e04cc8dfb\Symfony\Component\Console\Application->doRunCommand()
#25 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(157): _PHPStan_e04cc8dfb\Symfony\Component\Console\Application->doRun()
#26 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/bin/phpstan(94): _PHPStan_e04cc8dfb\Symfony\Component\Console\Application->run()
#27 phar://C:/dvl/Workspace/phpstan-dba/vendor/phpstan/phpstan/phpstan.phar/bin/phpstan(95): _PHPStan_e04cc8dfb\{closure}()
#28 C:\dvl\Workspace\phpstan-dba\vendor\phpstan\phpstan\phpstan(8): require('...')
#29 C:\dvl\Workspace\phpstan-dba\vendor\bin\phpstan(107): include('...')
#30 {main}

gets thrown in my pdo->query -DynamicMethodReturnTypeExtension, which can be seen in staabm/phpstan-dba#48

on phpstan 1.3.3

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.

It will most likely be closed after manual review.

[staabm]

ohh it seems I need to use

ParametersAcceptorSelector::selectFromArgs(
			$scope,
			$methodCall->getArgs(),
			$methodReflection->getVariants(),
		)->getReturnType();

instead.. I guess because the method in question has multiple signatures in https://github.com/phpstan/phpstan-src/blob/a9881e3afd4a105f0bd1391fb57a8e5c3462d2bc/resources/functionMap.php#L8451-L8454

what do you think about throwing a more meaningfull exception, with a hint what the problem is (in case there is more then 1 signature available)?

[ondrejmirtes]

Yes: phpstan/phpstan-src@d3c3483

[ondrejmirtes]

Also: Please don't rename the issue after you create it. It creates multiple threads in my inbox and it's hard to orient myself in that :)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.