We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello, It looks like \DomDocument::save() isn't expected to return false by phpstan
\DomDocument::save()
Snippet
I'm getting an error Method HelloWorld::storePayload() never returns false so it can be removed from the return type.
Method HelloWorld::storePayload() never returns false so it can be removed from the return type.
Method signature is public DOMDocument::save(string $filename, int $options = 0): int|false , so indeed it can return false 😉
public DOMDocument::save(string $filename, int $options = 0): int|false
Sure! :)
The text was updated successfully, but these errors were encountered:
Needs fixing in the signature file https://github.com/phpstan/phpstan-src/blob/daf7d5577bd8c796509768eb6a8d2862b6027a53/resources/functionMap.php#L1924
Could you send a PR?
Sorry, something went wrong.
Sure: phpstan/phpstan-src#956
Fixed by phpstan/phpstan-src#956
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
No branches or pull requests
Bug report
Hello,
It looks like
\DomDocument::save()
isn't expected to return false by phpstanCode snippet that reproduces the problem
Snippet
I'm getting an error
Method HelloWorld::storePayload() never returns false so it can be removed from the return type.
Expected output
Method signature is
public DOMDocument::save(string $filename, int $options = 0): int|false
, so indeed it can return false 😉Did PHPStan help you today? Did it make you happy in any way?
Sure! :)
The text was updated successfully, but these errors were encountered: