Incorrect return type on curl_getinfo($ch, CURLINFO_CONTENT_TYPE)

[oschwald]

Bug report

As of PHPStan 1.5.0 and 1.5.1, the return type on curl_getinfo($ch, CURLINFO_CONTENT_TYPE) seems to string even though false will be returned when the header is not present.

I did glance at the PR that added the dynamic types and the author seems to have intended to handle this case. It was not immediately clear to me why it wasn't working.

Code snippet that reproduces the problem

For instance, the following code results in an error:

        $contentType = curl_getinfo($curl, \CURLINFO_CONTENT_TYPE);


        return [
            $statusCode,
            ($contentType === false ? null : $contentType),
            ...
        ]

See this link.

Output:

 ------ -------------------------------------------------------------------------------------
  Line   src/WebService/Http/CurlRequest.php
 ------ -------------------------------------------------------------------------------------
  132    Strict comparison using === between string and false will always evaluate to false.
 ------ -------------------------------------------------------------------------------------

Build failure.

Expected output

I expect no output from this code.

Did PHPStan help you today? Did it make you happy in any way?

PHPStan is extremely helpful in finding issues without running and testing the code.

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.

It will most likely be closed after manual review.

[oschwald]

phpstan.org reproduction.

[staabm]

Needs fixing in

https://github.com/phpstan/phpstan-src/blob/0f5b4bf5235b26c841d070170962c086ad7c0e04/src/Type/Php/CurlGetinfoFunctionDynamicReturnTypeExtension.php#L96

[ondrejmirtes]

Fixed by phpstan/phpstan-src#1170

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.