Infinite loop while scanning certain file

[danog]

Bug report

An infinite loop occurs while scanning a certain project.

Code snippet that reproduces the problem

Extract https://paste.daniil.it/phpstan.tar.xz and run composer update; .../phpstan-src/bin/phpstan analyze -vvv --xdebug --debug Module/Article/DataProvider/RegOwnerSteps.php

Expected output

No infinite loop

Did PHPStan help you today? Did it make you happy in any way?

<3

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.

It will most likely be closed after manual review.

[herndlm]

thx for the reproducer, I can take a look again later today. Does it also happen without --xdebug and --debug?

[danog]

Yep, it happens even with no flags as long as the vendor folder and composer.lock are both populated.

[bartv2]

Just had a look, it eats memory in 1.5.2 but just works in the 1.7.x branch. So fixed?

[herndlm]

I did actually forget about this, sorry.. But maybe it was part of some other endless recursion fixes we did recently. Is it also fixed on 1.6.x?
But anyways, if there's no endless loop anymore it is fixed I guess. Would be still great to find out which part caused it and add a regression test for it, so maybe this should still stay open. My guess: something related to traits. Or, if it still occurs on 1.6.x - most likely the fully static reflection changes in 1.7.x?

[bartv2]

This is the commit that fixed this, but at first glance it doesn't look like a proper fix.

[ondrejmirtes]

Can anyone volunteer to add it to integration tests in phpstan/phpstan similarly to this commit? Thanks! 5a8fb50

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.