Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False-positive expects Bar, Bar|Foo given while using match with collections #7593

Closed
fluffycondor opened this issue Jul 7, 2022 · 1 comment · Fixed by phpstan/phpstan-src#1574

Comments

@fluffycondor
Copy link
Contributor

Bug report

Looks like PHPStan thinks there are four code paths may be executed:

  • $fooCollection->add(Foo::class)
  • $fooCollection->add(Bar::class)
  • $barCollection->add(Foo::class)
  • $barCollection->add(Bar::class)

But actually there are only two paths, $fooCollection->add(Foo::class) and $barCollection->add(Bar::class).

Code snippet that reproduces the problem

https://phpstan.org/r/4a41044b-cdcb-4466-9043-a9c050420d4d

Expected output

No errors.

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant