Incorrect array_search() type under certain conditions

[zeriyoshi]

Bug report

Passing the $strict argument of array_search() from a function reports the possibility of null being returned.

Code snippet that reproduces the problem

https://phpstan.org/r/063ed345-07db-45c1-8b05-0fee820294cd

Expected output

array_search() will never return null in any case.

• https://github.com/php/php-src/blob/master/ext/standard/basic_functions.stub.php#L146

Did PHPStan help you today? Did it make you happy in any way?

Thanks to PHPStan, various bugs have been prevented. Awesome!

[herndlm]

the return type extension for array_search looks quite complicated, I think it can be refactored and cleaned up bit. irregardless, it looks like null is returned in pre PHP 8 if the second argument is not an array for example https://3v4l.org/8nMtV. but there are a couple of old tests for that already.

it should no be returned in your case though, I agree.

[zeriyoshi]

I was not aware of the possibility of null being returned in PHP 7.4. Thanks. You might want to handle this based on the value of the phpVersion configuration. (but may be unnecessary since it should be detected as an illegal argument in the first place)

https://phpstan.org/config-reference#phpversion

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.