Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should warn about unreachable default match arm with enums #8240

Closed
canvural opened this issue Oct 29, 2022 · 1 comment · Fixed by phpstan/phpstan-src#2105
Closed

Should warn about unreachable default match arm with enums #8240

canvural opened this issue Oct 29, 2022 · 1 comment · Fixed by phpstan/phpstan-src#2105
Labels
Milestone

Comments

@canvural
Copy link
Contributor

Bug report

Code snippet that reproduces the problem

<?php declare(strict_types = 1);

enum Foo {
	case BAR;
}

function doFoo(Foo $foo): int {
	return match($foo) {
		Foo::BAR => 5,
		default => throw new Exception('This will not be executed')
	};
}

https://phpstan.org/r/546a29d0-5aee-473e-a565-879644ed30d2

It reports error without enum: https://phpstan.org/r/b30674fc-ca2b-4b39-b1f9-ba57088054b1 (although looks like the order of default arm effects the analysis. maybe that should be another issue)

Expected output

Expecting an error at line 10 saying this match arm is unreachable. Because all possible enum values are already handled.

Did PHPStan help you today? Did it make you happy in any way?

Yes! ❤️

@canvural canvural changed the title Should warn about unreachable default match arm Should warn about unreachable default match arm with enums Oct 29, 2022
@ondrejmirtes ondrejmirtes added this to the Easy fixes milestone Dec 15, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants