You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
------ ------------------------------------------------------------------------------------------------------------------------
Line config/packages/framework.php
------ ------------------------------------------------------------------------------------------------------------------------
22 Call to an undefined method Symfony\Config\Framework\SessionConfig|Symfony\Config\FrameworkConfig::enabled().
------ ------------------------------------------------------------------------------------------------------------------------
But in phpstan/phpstan-src#1013@Seldaek (probably to fix a wrapping issue reported in #5013 by @ruudk) changed the output to a different hyperlink format which is not supported by all consoles.
So what I am getting since then is:
------ ------------------------------------------------------------------------------------------------------------------------
Line config/packages/framework.php
------ ------------------------------------------------------------------------------------------------------------------------
22 Call to an undefined method Symfony\Config\Framework\SessionConfig|Symfony\Config\FrameworkConfig::enabled().
✏️ config/packages/framework.php
------ ------------------------------------------------------------------------------------------------------------------------
This is not clickable anymore (for me); and this is the regression that @Chris53897 reported in #7796 (and this is still not fixed in 1.9.3).
Now in phpstan/phpstan-src#2035@janedbal changed the visible part of this hyperlink to show the full file path.
At least, that's what I'm guessing from the description, cause hyperlinks aren't working for me, so I can't show you the output ;-)
Solution
Let's summarize what people are wanting:
@Chris53897 and me want the old phpstorm://... format back, cause that's the only one that's working in their console.
@Seldaek and @ruudk want to keep the new hyperlink format, cause the phpstorm://... links can get too long, and if the line gets wrapped, the link is not working anymore (right?).
@janedbal wants the full file path to be displayed. (Ironically, the old phpstorm://... would have featured this ;-)
1 and 2 look incompatible to me, so I can't see any other way than to support both by introducing a new config option. My suggestion: Use the new editorUrlTitle for this: If it is present, use the new hyperlink format (with editorUrlTitles value as visible part); if it's not present, use the old phpstorm://... format.
The text was updated successfully, but these errors were encountered:
History
Out of the box, the output looks like this:
Now, in phpstan/phpstan-src#515 I introduced
editorUrl
:With this in your
phpstan.neon
:...the output changes to:
AFAIK, this line is clickable in any console (if you register the
phpstorm://
protocol). And this is also the documented status at https://phpstan.org/user-guide/output-format#opening-file-in-an-editorBut in phpstan/phpstan-src#1013 @Seldaek (probably to fix a wrapping issue reported in #5013 by @ruudk) changed the output to a different hyperlink format which is not supported by all consoles.
So what I am getting since then is:
This is not clickable anymore (for me); and this is the regression that @Chris53897 reported in #7796 (and this is still not fixed in 1.9.3).
Now in phpstan/phpstan-src#2035 @janedbal changed the visible part of this hyperlink to show the full file path.
At least, that's what I'm guessing from the description, cause hyperlinks aren't working for me, so I can't show you the output ;-)
Solution
Let's summarize what people are wanting:
phpstorm://...
format back, cause that's the only one that's working in their console.phpstorm://...
links can get too long, and if the line gets wrapped, the link is not working anymore (right?).phpstorm://...
would have featured this ;-)1 and 2 look incompatible to me, so I can't see any other way than to support both by introducing a new config option. My suggestion: Use the new
editorUrlTitle
for this: If it is present, use the new hyperlink format (witheditorUrlTitle
s value as visible part); if it's not present, use the oldphpstorm://...
format.The text was updated successfully, but these errors were encountered: