Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong parameter infer in PDO::sqliteCreateFunction #8802

Closed
denis-rossati opened this issue Jan 30, 2023 · 3 comments · Fixed by phpstan/phpstan-src#2208
Closed

Wrong parameter infer in PDO::sqliteCreateFunction #8802

denis-rossati opened this issue Jan 30, 2023 · 3 comments · Fixed by phpstan/phpstan-src#2208

Comments

@denis-rossati
Copy link

denis-rossati commented Jan 30, 2023 •
edited

Bug report

PHPStan 1.9.14 doesn't check the required number of params correctly at PDO::sqliteCreateFunction. I did not check if the same occurs in previous versions.

Code snippet that reproduces the problem

Expected output

The documentation states that you can pass up to 4 parameters, therefore I expected 0 errors.

Did PHPStan help you today? Did it make you happy in any way?

Where I work we use phpstan in every single PHP project and it helps a lot! As a beginner programmer, I am living prove that the assertions are accurate and the errors are very friendly :) please, don't stop the great work!
@denis-rossati denis-rossati changed the title Wrong parameter number assertion in PDO::sqliteCreateFunction Wrong parameter infer in PDO::sqliteCreateFunction Jan 30, 2023
@VincentLanglet VincentLanglet mentioned this issue Jan 30, 2023
Merged
@VincentLanglet
Copy link
Contributor

I opened phpstan/phpstan-src#2208 @denis-rossati
Thanks for the report

@denis-rossati
Copy link
Author

Thanks a lot for the agility!

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sqliteCreateFunction signature VincentLanglet/phpstan-src
2 participants
@VincentLanglet @denis-rossati