Add template support to callable property phpdoc

[mvorisek]

Feature request

https://phpstan.org/r/fb6ebb4f-3db2-4c46-99b3-be10a1afacf5

https://phpstan.org/r/7e370b44-57fa-4bcf-9a1d-24a0bbf3834e

Closure type in property should be possible to describe the same way as in method phpdoc.

[ondrejmirtes]

What you're asking for is generic callables/closures: Closure<T>(T): T.

@template above a method makes the method generic, but not the closure.

This is very easy to achieve since both CallableType and ClosureType can contain TemplateTypeMap. We need support for this syntax in phpstan/phpdoc-parser.

[phpstan-bot]

@mvorisek After the latest push in 1.10.x, PHPStan now reports different result with your code snippet:

@@ @@
 13: PHPDoc tag @var for property Cl::$prop contains unresolvable type.
-13: Property Cl::$prop has no type specified.
+13: Property Cl::$prop has no type specified.
+19: Tip: Method Cl::method() always throws an exception, it should have return type "never".

Full report

Line	Error
13	PHPDoc tag @var for property Cl::$prop contains unresolvable type.
13	Property Cl::$prop has no type specified.
19	Tip: Method Cl::method() always throws an exception, it should have return type "never".

[dktapps]

Fixed a mistake in your example: https://phpstan.org/r/fb6ebb4f-3db2-4c46-99b3-be10a1afacf5

[mvorisek]

@dktapps yes, thank you, I have updated the description. (if anyone read this, there was a typo CLosure instead of Closure, although it should be the same as CN are CI, phpstan does some matches in CS fashion)

[mvorisek]

What you're asking for is generic callables/closures: Closure<T>(T): T.

@template above a method makes the method generic, but not the closure.

This is very easy to achieve since both CallableType and ClosureType can contain TemplateTypeMap. We need support for this syntax in phpstan/phpdoc-parser.

Hi @ondrejmirtes, implemented in phpstan/phpdoc-parser#199, can I please ask you to review it?

[mvorisek]

@param callable template support has been added in phpstan/phpstan-src#2938

however assign to a property is still not working - https://phpstan.org/r/7e370b44-57fa-4bcf-9a1d-24a0bbf3834e

/cc @mad-briller

[ondrejmirtes]

Closures do not support PHPDocs above them, you can't mark your closure as generic.

There's an open feature request about PHPDocs above closures.

[mvorisek]

Closures do not support PHPDocs above them, you can't mark your closure as generic.

You probably opened the (old) repro from this issue description, in the last post, I have linked sensual repro. To avoid confusion, I have linked it in the issue description as well.

[ondrejmirtes]

The question is - why it works for methods and not for property assignments. I'm not really sure.

Another question is - how these should be validated in regard to generics and TemplateTypeMap, I'm also not sure.

[mvorisek]

Here is a little better repro - https://phpstan.org/r/bb9171d8-60f4-477c-9b2a-3e8d867d3a74

$o->prop = function (Model $c) {};

passes but

$o->prop = function (ModelCountry $c) {};

emits phpstan error.

It seems the callable template of the property is resolved before the assign.