filter_var_array with a mixed argument results in a fatal error

[daniel-calderini]

Bug report

Starting with version 1.10.12, the following code snippet creates a fatal error:

function filter(mixed $data): array
{
	return filter_var_array(
		$data,
		[
			'id' => [
				'filter' => FILTER_VALIDATE_INT,
				'flags' => FILTER_REQUIRE_SCALAR,
			],
		
		],
		true,
	);
}

https://phpstan.org/r/432b5663-9303-4742-969b-f4ac0a168e68

Using version 1.10.11 (or lower), or using array type for the $data argument fixes the fatal error:

function filter(array $data): array
{
	return filter_var_array(
		$data,
		[
			'id' => [
				'filter' => FILTER_VALIDATE_INT,
				'flags' => FILTER_REQUIRE_SCALAR,
			],
		
		],
		true,
	);
}

https://phpstan.org/r/4906b331-8a8d-45c3-860b-2d7039afa990

[ondrejmirtes]

/cc @zonuexe Please send a PR with a fix.

Personally I'd fix the code like this to make it safe and not crash

diff --git a/src/Type/Php/FilterVarArrayDynamicReturnTypeExtension.php b/src/Type/Php/FilterVarArrayDynamicReturnTypeExtension.php
index ac57eb12c..b2ca7f42c 100644
--- a/src/Type/Php/FilterVarArrayDynamicReturnTypeExtension.php
+++ b/src/Type/Php/FilterVarArrayDynamicReturnTypeExtension.php
@@ -78,9 +78,6 @@ class FilterVarArrayDynamicReturnTypeExtension implements DynamicFunctionReturnT
 		$addEmpty = $addEmptyType === null || $addEmptyType->isTrue()->yes();
 
 		$valueTypesBuilder = ConstantArrayTypeBuilder::createEmpty();
-		$inputTypesMap = [];
-		$optionalKeys = [];
-
 		if ($filterArgType instanceof ConstantIntegerType) {
 			if ($inputConstantArrayType === null) {
 				$isList = $inputArrayType->isList()->yes();
@@ -148,6 +145,9 @@ class FilterVarArrayDynamicReturnTypeExtension implements DynamicFunctionReturnT
 				}
 			} else {
 				$optionalKeys = $filterKeysList;
+				if (count($inputArrayType->getArrays()) !== 1) {
+					return null;
+				}
 				$inputTypesMap = array_fill_keys($optionalKeys, $inputArrayType->getArrays()[0]->getItemType());
 			}
 		}

But it infers the call to be array|false|null. Maybe there's a better way. Thanks.

[zonuexe]

Thanks for the report, I'll start fixing it.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.