treatPhpDocTypesAsCertain: false leads to ERROR type

[schlndh]

Bug report

I tried setting treatPhpDocTypesAsCertain: false and I got a bunch of weird issues reported. I eventually narrowed it down to this snippet: https://phpstan.org/r/31afc03c-8936-4cc4-b292-b48df3821292

IMO Dumped type: array<int|string, *ERROR*> is objectively wrong, since $items are certainly an array. (I'm not sure if *ERROR* makes sense here even if $items were non-iterable).

And then there's the second issue:

Parameter #1 $objects of method Aaa::acceptObjects() expects array<int, Item>, array<int|string, mixed> given.

I'm not sure if this is a consequence of the first issue, or if this is intended behavior. But in any case, it is not what I would expect based on the documentation of treatPhpDocTypesAsCertain. My understanding is that it should allow me to double-check if I'm getting the type specified in phpdoc or not, but it should otherwise assume that the phpdoc is correct.

Code snippet that reproduces the problem

https://phpstan.org/r/31afc03c-8936-4cc4-b292-b48df3821292 (same as above)

Expected output

It should behave the same as with treatPhpDocTypesAsCertain: true: Dumped type: array<int, Item>

[phpstan-bot]

@schlndh After the latest push in 1.11.x, PHPStan now reports different result with your code snippet:

@@ @@
-32: Dumped type: array<int|string, *ERROR*>
-34: Parameter #1 $objects of method Aaa::acceptObjects() expects array<int, Item>, array<int|string, mixed> given.
+32: Dumped type: array

Full report

Line	Error
32	Dumped type: array

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.