array_udiff() comparator type is too strict

[stefanfisk]

Bug report

array_udiff() comparators should return an integer less than, equal to, or greater than zero according to the docs, but PHPStan raises an issue if the comparator's return type is not int<-1,1>.

usort() does however accept any int.

Code snippet that reproduces the problem

https://phpstan.org/r/a036787e-1397-49a1-9391-891f4332df5b

Expected output

There should be no issues.

Did PHPStan help you today? Did it make you happy in any way?

It helped me catch a case where not all code paths returned a value!

[phpstan-bot]

@stefanfisk After the latest push in 1.11.x, PHPStan now reports different result with your code snippet:

@@ @@
 PHP 7.4 – 8.3 (1 error)
 ==========
 
-13: Parameter #3 $data_comp_func of function array_udiff expects callable(int, int): int<-1, 1>, Closure(int, int): int given.
+13: Parameter #3 $data_comp_func of function array_udiff expects callable(1|2|3, 1|2|3): int<-1, 1>, Closure(int, int): int given.
 
 PHP 7.2 – 7.3 (1 error)
 ==========
 
  6: Syntax error, unexpected T_VARIABLE, expecting ')' on line 6

Full report

PHP 7.4 – 8.3 (1 error)

Line	Error
13	`Parameter #3 $data_comp_func of function array_udiff expects callable(1

PHP 7.2 – 7.3 (1 error)

Line	Error
6	Syntax error, unexpected T_VARIABLE, expecting ')' on line 6

[ondrejmirtes]

Fixed phpstan/phpstan-src#2822

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.