phpredis method signatures are incorrect (should include false in return type hint)

[InvisibleSmiley]

Please send a pull request in phpstan/phpstan-src that updates file resources/functionMap.php instead. Thank you.

I don't have the time for that right now but would like to document what I found here so someone else can flesh it out.

I found that PHPStan complained that RedisArray::keys may not return false, but PhpStorm's stubs said it can.
Digging a little deeper I found that at some point in time the phpredis stubs have been updated, and consequently also the Psalm ones. Don't know who updated PhpStorm stubs, but obviously PHPStan missed it.

Related:

• Redis::keys may return false? phpredis/phpredis#2154
• WIP: Update stubs so the tests pass in strict mode phpredis/phpredis#2015
• Update Phpredis stubs to return false on failure vimeo/psalm#8555

[mergeable]

Hi there! 👋

Looks like you opened an issue without following one of the issue templates:

Bug report 🐛 (open an issue)

If something isn't working as expected 🤔.

Feature request 🚀 (open an issue)

I have a suggestion (and may want to implement it 🙂)!

Support question ❓ (open a discussion)

I need some help with my code because PHPStan doesn't like it.

---

The current issue will be closed. This is a precaution to save maintainer's time, I hope you'll understand.

Sincerely, the bot 🤖

[InvisibleSmiley]

Actually PHPStan not only missed the false possibility but is also too strict regarding the array structure.
We found that RedisArray::keys returns array<string, list<string>> while PHPStan says it's an array of strings.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.