Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cant compile the .ino :( #1

Closed
guidol70 opened this issue Dec 8, 2021 · 13 comments
Closed

cant compile the .ino :( #1

guidol70 opened this issue Dec 8, 2021 · 13 comments

Comments

@guidol70
Copy link
Collaborator

guidol70 commented Dec 8, 2021

I did try to compile the 2 .ino files, but do get an error while compiling :(
I have attached the errors as .txt file.
Do you got an idea what the problem could be?

I have made m_HVSyn public and commented it out in protected.

The view of code for the change in vgabasecontroller.h seems to depend on
FabGL v1.0.3 - because there is only the line
void setRawPixel(int x, int y, uint8_t rgb) { VGA_PIXEL(x, y) = rgb; }
in the file vgabasecontroller.h
In v1.0.4/v1.0.5 this line doesnt exist anymore :(

I also used ESP32 Core v1.0.6 because the most FabGL code doesnt compile with v2.0.0/v2.0.1

ino_compile_error.txt

@guidol70
Copy link
Collaborator Author

guidol70 commented Dec 8, 2021

from the error I did read that I have to move
intr_handle_t m_isr_handle;
also from protected to public

Now the .ino does compile :)

But how do I get the /data directory with the .r3 files/library in the ESP32 SPIFFS Filesystem?

Iam using a TTGO VGA32 (which is FabGL compatible).
Should these files on the internal fash (as the sketch says SPIFFS ) or on the SDCard (on a TTGO VGA32)?

[EDIT] for the SPIFFS-File-Upload you have to install/use the
ESP32 Filesystem Uploader from here

Copy the - in the .zip included - ESP32FS folder to your Arduino-Installtion in the folder tools :)

In the arduino-ide you will se the tool under Tools above the board-selection.

@phreda4
Copy link
Owner

phreda4 commented Dec 8, 2021

I not try with new version of fabgl library, I try upload all the library for you can download all.
give me a couple of days
secod, you are correct, need to upload the file data

@phreda4
Copy link
Owner

phreda4 commented Dec 8, 2021

I upload fabgl library in my system in
https://drive.google.com/file/d/1YbkTJF_VDOPd4IJRx6sm8HzJuiflE_bg/view?usp=sharing

this file is the folder
...\Documents\Arduino\libraries\FabGL
I remove docs and examples (80MB!!)
tellme if work !

@rpsubc8
Copy link
Collaborator

rpsubc8 commented Dec 8, 2021

Congratulations on the project. I have tested it on a TTGO VGA32 v1.2 and v1.4, and it works perfectly.
You don't have to take into account what I am going to tell you, since it is your project. But you could make a simple modification that would not need to modify the fabgl library:

class VGADirectControllerPublic : public fabgl::VGADirectController
{
public:
intr_handle_t GetISRHandle()
{
return m_isr_handle;
}
uint8_t GetHVSync()
{
return m_HVSync;
}
};

VGADirectControllerPublic DisplayController;

Here I have left more information with the code:

http://retrowiki.es/viewtopic.php?f=86&t=200036016&start=320

@guidol70
Copy link
Collaborator Author

guidol70 commented Dec 8, 2021

I upload fabgl library in my system in

this file is the folder ...\Documents\Arduino\libraries\FabGL
tellme if work !

I did work, but my Arduino IDE told me - after compiling - that you are using FabGL v1.0.2 and in your vgabasecontroller.h the
intr_handle_t m_isr_handle;
is already in the public portion of the file.
In the Read.Me at your github-page this information is missing.

@phreda4
Copy link
Owner

phreda4 commented Dec 8, 2021

Thank's a lot ackerman !!!
I add to the github for other users, send me you nick or name for add to the credits

guido, try the ackerman modificatios, is more clear, I need this modification because

  1. for speed, I generate pixels line by line.. not use the framebuffer..
  2. the interrupt need for make SPIFF operation..LOAD, SAVE, DIR.. I need disable the generation on vga signal..

if any can traslate to other lib or make a version without lib, count with my help.. this code only use a fraction of fabgl lib

@guidol70
Copy link
Collaborator Author

guidol70 commented Dec 8, 2021

Thank's a lot ackerman !!! I add to the github for other users, send me you nick or name for add to the credits

This are the changes to the .ino which the compare-funtion of Notepad++ did found between the actual github-version and the version from ackerman:

Modification_1

Modification_2

Now I can check (think ackerman checked it alread) to put back the 2 lines to protected and recompile with v1.0.5 ;)
[EDIT]
I successfully compiled it with an unchanged FabGL v1.0.5 (like ackerman).
When you have changed the .ino an the Read.Me we can strip the following line also from the .ino ;)

// * Use FabGL Library with 2 changes (http://www.fabglib.org)

@guidol70
Copy link
Collaborator Author

guidol70 commented Dec 8, 2021

Thank's a lot ackerman !!! I add to the github for other users, send me you nick or name for add to the credits

his nick should be:
https://github.com/rpsubc8 -> ackerman

@phreda4
Copy link
Owner

phreda4 commented Dec 8, 2021

Thank's guido, if you have github I add you to access too

@rpsubc8
Copy link
Collaborator

rpsubc8 commented Dec 8, 2021

Thank you very much, no need to include me in the credits. The important thing is to create a community of developers under ESP32, natively or emulation, and to be able to help each other.
In addition, of the esp32forthcomputer.ino, in the code I have also modified the r3.ino that is where the interrupts that phreda4 says are used:

void fastmode()
{
//esp_intr_disable(DisplayController.m_isr_handle);
esp_intr_disable(DisplayController.GetISRHandle());
}

void slowmode()
{
//esp_intr_enable(DisplayController.m_isr_handle);
esp_intr_enable(DisplayController.GetISRHandle());
}

If the m_isr_handle and m_HVSync change depending on the fabgl version, we just have to modify the GetISRHandle and GetHVSync method of esp32forthcomputer.ino the return it returns.

I have tested with fabgl v1.0.5 and Arduino IDE 1.8.11 (espressif 1.0.4 and 1.0.6).

@guidol70
Copy link
Collaborator Author

guidol70 commented Dec 8, 2021

Thank's guido, if you have github I add you to access too

If you click here in the Message-Thread on my nick "guidol70" you will see, that Iam on Github as https://github.com/guidol70
;)

@guidol70
Copy link
Collaborator Author

guidol70 commented Dec 8, 2021

I have tested with fabgl v1.0.5 and Arduino IDE 1.8.11 (espressif 1.0.4 and 1.0.6).

I have tested with fabgl v1.0.5 and Arduino IDE 1.8.16
(espressif ESP32 Core v1.0.6 ).
All fine :)

espressif ESP32 Core v2.0.0/v2.0.1 doesnt work with FabGL, so I have configured a portable 2nd installation with v1.0.6, because my main-installation uses v2.0.1 to support a ESP32-S2

@phreda4 phreda4 closed this as completed Dec 9, 2021
@guidol70
Copy link
Collaborator Author

you are correct, need to upload the file data

here could you find a updated .jar for the ESP32 File Uploader plugin which also support the newer ESP32-Chipsets (like ESP32-S2):
https://github.com/lorol/arduino-esp32fs-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants